Skip to content

Added feature for project contribution #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Icelery599
Copy link

this pull request is for a laravel project, the changes were made on the welcome.php page. please help confirm my request

@ganjarsetia
Copy link

ganjarsetia commented Jul 25, 2025

@Icelery599 I noticed your PR, but the change only adds a copyright line ©Icelery 2025 And I don't see your contribution in commits. Since this doesn’t introduce a new feature or fix an issue, the maintainers might not accept it. The change doesn't actually implement any new feature or improvement as mentioned in the PR title. Also adding personal copyright notices to project files is not considered a valid contribution.

If I'm wrong, tell us what is your contributions (like commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants